]> www.infradead.org Git - users/jedix/linux-maple.git/commit
KVM: arm64: Fix set_id_regs selftest for ASIDBITS becoming unwritable
authorMark Brown <broonie@kernel.org>
Mon, 16 Dec 2024 19:28:24 +0000 (19:28 +0000)
committerOliver Upton <oliver.upton@linux.dev>
Tue, 17 Dec 2024 09:14:56 +0000 (01:14 -0800)
commit212fbabe1dfecdda35bf5aaa900f745a3bab5ac4
tree5b3f91221716c9998470627fdfefbb502c54faa7
parent78d4f34e2115b517bcbfe7ec0d018bbbb6f9b0b8
KVM: arm64: Fix set_id_regs selftest for ASIDBITS becoming unwritable

In commit 03c7527e97f7 ("KVM: arm64: Do not allow ID_AA64MMFR0_EL1.ASIDbits
to be overridden") we made that bitfield in the ID registers unwritable
however the change neglected to make the corresponding update to set_id_regs
resulting in it failing:

  ok 56 ID_AA64MMFR0_EL1_BIGEND
  ==== Test Assertion Failure ====
    aarch64/set_id_regs.c:434: masks[idx] & ftr_bits[j].mask == ftr_bits[j].mask
    pid=5566 tid=5566 errno=22 - Invalid argument
       1 0x00000000004034a7: test_vm_ftr_id_regs at set_id_regs.c:434
       2 0x0000000000401b53: main at set_id_regs.c:684
       3 0x0000ffff8e6b7543: ?? ??:0
       4 0x0000ffff8e6b7617: ?? ??:0
       5 0x0000000000401e6f: _start at ??:?
not ok 8 selftests: kvm: set_id_regs # exit=254

Remove ID_AA64MMFR1_EL1.ASIDBITS from the set of bitfields we test for
writeability.

Signed-off-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20241216-kvm-arm64-fix-set-id-asidbits-v1-1-8b105b888fc3@kernel.org
Acked-by: Marc Zyngier <maz@kernel.org>
Signed-off-by: Oliver Upton <oliver.upton@linux.dev>
tools/testing/selftests/kvm/aarch64/set_id_regs.c