]> www.infradead.org Git - nvme.git/commit
drm/i915/dp: Don't switch the LTTPR mode on an active link
authorImre Deak <imre.deak@intel.com>
Mon, 8 Jul 2024 19:00:25 +0000 (22:00 +0300)
committerImre Deak <imre.deak@intel.com>
Thu, 11 Jul 2024 18:11:59 +0000 (21:11 +0300)
commit211ad49cf8ccfdc798a719b4d1e000d0a8a9e588
tree12173f9bffc17ebb301de2de4b12e68ea55c76a7
parenta4d5ce61765c08ab364aa4b327f6739b646e6cfa
drm/i915/dp: Don't switch the LTTPR mode on an active link

Switching to transparent mode leads to a loss of link synchronization,
so prevent doing this on an active link. This happened at least on an
Intel N100 system / DELL UD22 dock, the LTTPR residing either on the
host or the dock. To fix the issue, keep the current mode on an active
link, adjusting the LTTPR count accordingly (resetting it to 0 in
transparent mode).

v2: Adjust code comment during link training about reiniting the LTTPRs.
   (Ville)

Fixes: 7b2a4ab8b0ef ("drm/i915: Switch to LTTPR transparent mode link training")
Reported-and-tested-by: Gareth Yu <gareth.yu@intel.com>
Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10902
Cc: <stable@vger.kernel.org> # v5.15+
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240708190029.271247-3-imre.deak@intel.com
drivers/gpu/drm/i915/display/intel_dp_link_training.c