]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/msm/dpu: cast crtc_clk calculation to u64 in _dpu_core_perf_calc_clk()
authorZichen Xie <zichenxie0106@gmail.com>
Tue, 29 Oct 2024 19:42:10 +0000 (14:42 -0500)
committerDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Thu, 31 Oct 2024 21:27:07 +0000 (23:27 +0200)
commit20c7b42d9dbd048019bfe0af39229e3014007a98
treea2cf59a810e3121d29e9b076fa5d0b3e6d79c433
parentc36a410780a3c061ec82915d4c826c324ca43926
drm/msm/dpu: cast crtc_clk calculation to u64 in _dpu_core_perf_calc_clk()

There may be a potential integer overflow issue in
_dpu_core_perf_calc_clk(). crtc_clk is defined as u64, while
mode->vtotal, mode->hdisplay, and drm_mode_vrefresh(mode) are defined as
a smaller data type. The result of the calculation will be limited to
"int" in this case without correct casting. In screen with high
resolution and high refresh rate, integer overflow may happen.
So, we recommend adding an extra cast to prevent potential
integer overflow.

Fixes: c33b7c0389e1 ("drm/msm/dpu: add support for clk and bw scaling for display")
Signed-off-by: Zichen Xie <zichenxie0106@gmail.com>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/622206/
Link: https://lore.kernel.org/r/20241029194209.23684-1-zichenxie0106@gmail.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c