]> www.infradead.org Git - users/hch/xfsprogs.git/commit
xfs: properly handle free inodes in extent hint validators libxfs-4.18-sync
authorEric Sandeen <sandeen@redhat.com>
Fri, 27 Jul 2018 22:03:50 +0000 (17:03 -0500)
committerEric Sandeen <sandeen@redhat.com>
Fri, 27 Jul 2018 22:03:50 +0000 (17:03 -0500)
commit206bef93353fd32189341bcdee3dc54149f7e30e
tree84ef161cabb16389e8918e3597232ab12297e113
parentc25e430563281b8efc45d7877f40c8e7cdff80ee
xfs: properly handle free inodes in extent hint validators

Source kernel commit: d4a34e16555708bab5b67e679a95f055d8ef9882

When inodes are freed in xfs_ifree(), di_flags is cleared (so extent size
hints are removed) but the actual extent size fields are left intact.
This causes the extent hint validators to fail on freed inodes which once
had extent size hints.

This can be observed (for example) by running xfs/229 twice on a
non-crc xfs filesystem, or presumably on V5 with ikeep.

Fixes: 7d71a67 ("xfs: verify extent size hint is valid in inode verifier")
Fixes: 02a0fda ("xfs: verify COW extent size hint is valid in inode verifier")
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
libxfs/xfs_inode_buf.c