]> www.infradead.org Git - users/dwmw2/linux.git/commit
net/mlx5: SF, Fix add port error handling
authorChris Mi <cmi@nvidia.com>
Wed, 15 Jan 2025 11:39:06 +0000 (13:39 +0200)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 16 Jan 2025 11:45:47 +0000 (12:45 +0100)
commit2011a2a18ef00b5b8e4b753acbe6451a8c5f2260
treeb73799c5d5d89449b9934541938e906740320279
parent1b10a519a45704d4b06ebd9245b272d145752c18
net/mlx5: SF, Fix add port error handling

If failed to add SF, error handling doesn't delete the SF from the
SF table. But the hw resources are deleted. So when unload driver,
hw resources will be deleted again. Firmware will report syndrome
0x68def3 which means "SF is not allocated can not deallocate".

Fix it by delete SF from SF table if failed to add SF.

Fixes: 2597ee190b4e ("net/mlx5: Call mlx5_sf_id_erase() once in mlx5_sf_dealloc()")
Signed-off-by: Chris Mi <cmi@nvidia.com>
Reviewed-by: Shay Drori <shayd@nvidia.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c