]> www.infradead.org Git - users/dwmw2/qemu.git/commit
tcg: use QTree instead of GTree
authorEmilio Cota <cota@braap.org>
Sun, 5 Feb 2023 16:37:58 +0000 (11:37 -0500)
committerRichard Henderson <richard.henderson@linaro.org>
Tue, 28 Mar 2023 22:23:10 +0000 (15:23 -0700)
commit1ff4a81bd3efb207992f1da267886fe0c4df764f
tree4865036b91bf5cd4d4fc7df0764e1e35c1cefcea
parente3feb2cc224f61149a27f021042f5a4230bb1008
tcg: use QTree instead of GTree

qemu-user can hang in a multi-threaded fork. One common
reason is that when creating a TB, between fork and exec
we manipulate a GTree whose memory allocator (GSlice) is
not fork-safe.

Although POSIX does not mandate it, the system's allocator
(e.g. tcmalloc, libc malloc) is probably fork-safe.

Fix some of these hangs by using QTree, which uses the system's
allocator regardless of the Glib version that we used at
configuration time.

Tested with the test program in the original bug report, i.e.:
```

void garble() {
  int pid = fork();
  if (pid == 0) {
    exit(0);
  } else {
    int wstatus;
    waitpid(pid, &wstatus, 0);
  }
}

void supragarble(unsigned depth) {
  if (depth == 0)
    return ;

  std::thread a(supragarble, depth-1);
  std::thread b(supragarble, depth-1);
  garble();
  a.join();
  b.join();
}

int main() {
  supragarble(10);
}
```

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/285
Reported-by: Valentin David <me@valentindavid.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Emilio Cota <cota@braap.org>
Message-Id: <20230205163758.416992-3-cota@braap.org>
[rth: Add QEMU_DISABLE_CFI for all callback using functions.]
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
accel/tcg/tb-maint.c
tcg/region.c
util/qtree.c