]> www.infradead.org Git - users/jedix/linux-maple.git/commit
EDAC/bluefield: Fix potential integer overflow
authorDavid Thompson <davthompson@nvidia.com>
Mon, 30 Sep 2024 15:10:56 +0000 (11:10 -0400)
committerBorislav Petkov (AMD) <bp@alien8.de>
Thu, 17 Oct 2024 12:10:18 +0000 (14:10 +0200)
commit1fe774a93b46bb029b8f6fa9d1f25affa53f06c6
tree111235bea66190b740bf4cdffb65c0e7b25cf9f7
parent0be9f1af39022beac76771eeac08256076f6b221
EDAC/bluefield: Fix potential integer overflow

The 64-bit argument for the "get DIMM info" SMC call consists of mem_ctrl_idx
left-shifted 16 bits and OR-ed with DIMM index.  With mem_ctrl_idx defined as
32-bits wide the left-shift operation truncates the upper 16 bits of
information during the calculation of the SMC argument.

The mem_ctrl_idx stack variable must be defined as 64-bits wide to prevent any
potential integer overflow, i.e. loss of data from upper 16 bits.

Fixes: 82413e562ea6 ("EDAC, mellanox: Add ECC support for BlueField DDR4")
Signed-off-by: David Thompson <davthompson@nvidia.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Shravan Kumar Ramani <shravankr@nvidia.com>
Link: https://lore.kernel.org/r/20240930151056.10158-1-davthompson@nvidia.com
drivers/edac/bluefield_edac.c