]> www.infradead.org Git - users/jedix/linux-maple.git/commit
irqchip/riscv-aplic: Prevent crash when MSI domain is missing
authorSamuel Holland <samuel.holland@sifive.com>
Thu, 14 Nov 2024 20:01:30 +0000 (12:01 -0800)
committerThomas Gleixner <tglx@linutronix.de>
Fri, 15 Nov 2024 23:45:37 +0000 (00:45 +0100)
commit1f181d1cda56c2fbe379c5ace1aa1fac6306669e
treec48eb258edbf654b78c7cca34905b45b780532b8
parentf9ed1f7c2e26fcd19781774e310a6236d7525c11
irqchip/riscv-aplic: Prevent crash when MSI domain is missing

If the APLIC driver is probed before the IMSIC driver, the parent MSI
domain will be missing, which causes a NULL pointer dereference in
msi_create_device_irq_domain().

Avoid this by deferring probe until the parent MSI domain is available. Use
dev_err_probe() to avoid printing an error message when returning
-EPROBE_DEFER.

Fixes: ca8df97fe679 ("irqchip/riscv-aplic: Add support for MSI-mode")
Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20241114200133.3069460-1-samuel.holland@sifive.com
drivers/irqchip/irq-riscv-aplic-main.c
drivers/irqchip/irq-riscv-aplic-msi.c