]> www.infradead.org Git - users/dwmw2/linux.git/commit
net: skb_reset_mac_len() must check if mac_header was set
authorEric Dumazet <edumazet@google.com>
Tue, 5 Nov 2024 17:43:57 +0000 (17:43 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 7 Nov 2024 01:29:14 +0000 (17:29 -0800)
commit1e4033b53db48cc77c436feac9c6d7d63db87b87
tree01d711ab7fb8dcfa56a3e9c361ca55ff81feec1a
parent3545f9b72f3e0edc43cd807a5c987656ca0a22aa
net: skb_reset_mac_len() must check if mac_header was set

Recent discussions show that skb_reset_mac_len() should be more careful.

We expect the MAC header being set.

If not, clear skb->mac_len and fire a warning for CONFIG_DEBUG_NET=y builds.

If after investigations we find that not having a MAC header was okay,
we can remove the warning.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/netdev/CANn89iJZGH+yEfJxfPWa3Hm7jxb-aeY2Up4HufmLMnVuQXt38A@mail.gmail.com/T/
Cc: En-Wei Wu <en-wei.wu@canonical.com>
Reviewed-by: Joe Damato <jdamato@fastly.com>
Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Link: https://patch.msgid.link/20241105174403.850330-2-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/linux/skbuff.h