]> www.infradead.org Git - users/jedix/linux-maple.git/commit
rtc: pcf8563: fix wrong alarm register
authorTroy Mitchell <troymitchell988@gmail.com>
Sat, 31 May 2025 07:20:40 +0000 (15:20 +0800)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Sun, 1 Jun 2025 22:00:37 +0000 (00:00 +0200)
commit1e15a6803df01471e0065dabd8b9563692c47219
treeda3350df63c19c4cde31f563e4c45381d47e5868
parentf096bdbf08c9c696a6b5c18a36b75c43f8d86eba
rtc: pcf8563: fix wrong alarm register

When the regmap framework was introduced to this driver,
the PCF8563_REG_AMN register within the set_alarm function was
incorrectly changed to PCF8563_REG_SC.

The PCF8563_REG_SC register is the seconds register.
This caused alarm values to be written to the seconds register
when an alarm was set. Which means the alarm would not trigger
as expected and the seconds register would be overwritten
with an incorrect value.

Signed-off-by: Troy Mitchell <troymitchell988@gmail.com>
Link: https://lore.kernel.org/r/20250531-pcf8563-fix-alarm-v2-1-cac4b1716167@gmail.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-pcf8563.c