]> www.infradead.org Git - users/dwmw2/linux.git/commit
ksmbd: fix WARNING "do not call blocking ops when !TASK_RUNNING"
authorNamjae Jeon <linkinjeon@kernel.org>
Tue, 15 Apr 2025 00:26:10 +0000 (09:26 +0900)
committerSteve French <stfrench@microsoft.com>
Tue, 15 Apr 2025 03:21:26 +0000 (22:21 -0500)
commit1df0d4c616138784e033ad337961b6e1a6bcd999
treeb5c30e9c632c5445bb5a37df9bf8c74d36c347c2
parent1e440d5b25b7efccb3defe542a73c51005799a5f
ksmbd: fix WARNING "do not call blocking ops when !TASK_RUNNING"

wait_event_timeout() will set the state of the current
task to TASK_UNINTERRUPTIBLE, before doing the condition check. This
means that ksmbd_durable_scavenger_alive() will try to acquire the mutex
while already in a sleeping state. The scheduler warns us by giving
the following warning:

do not call blocking ops when !TASK_RUNNING; state=2 set at
 [<0000000061515a6f>] prepare_to_wait_event+0x9f/0x6c0
WARNING: CPU: 2 PID: 4147 at kernel/sched/core.c:10099 __might_sleep+0x12f/0x160

mutex lock is not needed in ksmbd_durable_scavenger_alive().

Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/server/vfs_cache.c