]> www.infradead.org Git - users/jedix/linux-maple.git/commit
timers: Add missing READ_ONCE() in __run_timer_base()
authorThomas Gleixner <tglx@linutronix.de>
Wed, 30 Oct 2024 07:53:51 +0000 (08:53 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Thu, 31 Oct 2024 10:45:01 +0000 (11:45 +0100)
commit1d4199cbbe95efaba51304cfd844bd0ccd224e61
tree872223b5a525f3297ab928baa203cf6e80f61596
parentbf9a001fb8e46a23c43d4964523963e717d9e972
timers: Add missing READ_ONCE() in __run_timer_base()

__run_timer_base() checks base::next_expiry without holding
base::lock. That can race with a remote CPU updating next_expiry under the
lock. This is an intentional and harmless data race, but lacks a
READ_ONCE(), so KCSAN complains about this.

Add the missing READ_ONCE(). All other places are covered already.

Fixes: 79f8b28e85f8 ("timers: Annotate possible non critical data race of next_expiry")
Reported-by: kernel test robot <oliver.sang@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Link: https://lore.kernel.org/all/87a5emyqk0.ffs@tglx
Closes: https://lore.kernel.org/oe-lkp/202410301205.ef8e9743-lkp@intel.com
kernel/time/timer.c