]> www.infradead.org Git - users/jedix/linux-maple.git/commit
media: atomisp: Avoid picking too big sensor resolution
authorHans de Goede <hdegoede@redhat.com>
Wed, 11 Dec 2024 17:35:16 +0000 (18:35 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 5 May 2025 07:47:27 +0000 (09:47 +0200)
commit1d2e5bef1315fe5d92cb087beaba5d7b2c8d2cff
treef480b705a91b69065347836052f9dda74b21bf76
parent48ba117fadaf09b076c81e500a74f79646381fa8
media: atomisp: Avoid picking too big sensor resolution

atomisp_try_fmt() is limiting the width of the requested resolution to 1920
before calling the sensor's try_fmt() method. But it is not limiting
the height. In case of the old mode-list based t4ka3 driver which has
a mode list of:

736x496
896x736
1936x1096
3280x2464

This results in 3280x2464 being selected when try_fmt is called
with a requested resolution of 3280x2464, which is not supported because
its width > 1920 .

Fix this by also limiting the height when in preview mode.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20241211173516.350779-1-hdegoede@redhat.com
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/pci/atomisp_cmd.c