]> www.infradead.org Git - users/dwmw2/linux.git/commit
netfilter: nf_tables: reject mismatching sum of field_len with set key length
authorPablo Neira Ayuso <pablo@netfilter.org>
Tue, 28 Jan 2025 11:26:33 +0000 (12:26 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Thu, 30 Jan 2025 11:26:11 +0000 (12:26 +0100)
commit1b9335a8000fb70742f7db10af314104b6ace220
treef247f87b71ca09d41069f9c14bc0c5672da2a827
parent0a5b8fff01bde1b9908f00004c676f2e2459333b
netfilter: nf_tables: reject mismatching sum of field_len with set key length

The field length description provides the length of each separated key
field in the concatenation, each field gets rounded up to 32-bits to
calculate the pipapo rule width from pipapo_init(). The set key length
provides the total size of the key aligned to 32-bits.

Register-based arithmetics still allows for combining mismatching set
key length and field length description, eg. set key length 10 and field
description [ 5, 4 ] leading to pipapo width of 12.

Cc: stable@vger.kernel.org
Fixes: 3ce67e3793f4 ("netfilter: nf_tables: do not allow mismatch field size and set key length")
Reported-by: Noam Rathaus <noamr@ssd-disclosure.com>
Reviewed-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_tables_api.c