]> www.infradead.org Git - users/jedix/linux-maple.git/commit
blk-mq: fix use-after-free in blk_mq_free_tag_set()
authorJunichi Nomura <j-nomura@ce.jp.nec.com>
Wed, 14 Oct 2015 05:02:15 +0000 (05:02 +0000)
committerBrian Maly <brian.maly@oracle.com>
Mon, 23 Apr 2018 20:17:06 +0000 (16:17 -0400)
commit1aebfd675cb6c045418bbba9e7116ce2b4106ab0
tree3ee72b570402abefe2fc972090c3a45891a1a5b9
parent31704a11616772b69841a6d811fb82e577efc4fe
blk-mq: fix use-after-free in blk_mq_free_tag_set()

tags is freed in blk_mq_free_rq_map() and should not be used after that.
The problem doesn't manifest if CONFIG_CPUMASK_OFFSTACK is false because
free_cpumask_var() is nop.

tags->cpumask is allocated in blk_mq_init_tags() so it's natural to
free cpumask in its counter part, blk_mq_free_tags().

Fixes: f26cdc8536ad ("blk-mq: Shared tag enhancements")
Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Cc: Keith Busch <keith.busch@intel.com>
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
(cherry picked from  f42d79ab67322e51b92dd7aa965e310c71352a64 )
Orabug: 27892359

Reviewed-by: Thomas Tai <thomas.tai@oracle.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Jianchao Wang <jianchao.w.wang@oracle.com>
Signed-off-by: Brian Maly <brian.maly@oracle.com>
block/blk-mq-tag.c
block/blk-mq.c