]> www.infradead.org Git - users/jedix/linux-maple.git/commit
net: dsa: microchip: fix DCB apptrust configuration on KSZ88x3
authorOleksij Rempel <o.rempel@pengutronix.de>
Fri, 21 Mar 2025 14:10:44 +0000 (15:10 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 25 Mar 2025 17:40:54 +0000 (10:40 -0700)
commit1ae1d705a1120e8e0ca41698c5a0fff6f5290bc1
tree23686fb3109ff80d8b82b7df36a23ca8a6601913
parent0032c99e83b9ce6d5995d65900aa4b6ffb501cce
net: dsa: microchip: fix DCB apptrust configuration on KSZ88x3

Remove KSZ88x3-specific priority and apptrust configuration logic that was
based on incorrect register access assumptions. Also fix the register
offset for KSZ8_REG_PORT_1_CTRL_0 to align with get_port_addr() logic.

The KSZ88x3 switch family uses a different register layout compared to
KSZ9477-compatible variants. Specifically, port control registers need
offset adjustment through get_port_addr(), and do not match the datasheet
values directly.

Commit a1ea57710c9d ("net: dsa: microchip: dcb: add special handling for
KSZ88X3 family") introduced quirks based on datasheet offsets, which do
not work with the driver's internal addressing model. As a result, these
quirks addressed the wrong ports and caused unstable behavior.

This patch removes all KSZ88x3-specific DCB quirks and corrects the port
control register offset, effectively restoring working and predictable
apptrust configuration.

Fixes: a1ea57710c9d ("net: dsa: microchip: dcb: add special handling for KSZ88X3 family")
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250321141044.2128973-1-o.rempel@pengutronix.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/microchip/ksz8.c
drivers/net/dsa/microchip/ksz_dcb.c