]> www.infradead.org Git - users/dwmw2/linux.git/commit
net_sched: remove a redundant goto chain check
authorCong Wang <xiyou.wangcong@gmail.com>
Mon, 28 Sep 2020 18:31:03 +0000 (11:31 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 28 Sep 2020 19:58:45 +0000 (12:58 -0700)
commit1aad8049909a6d3379175ef2824a68ac35c0b564
treec24b33b8d98025e80da071fb8ff2cb90db5df0f8
parentf2f3729fb65c5c2e6db234e6316b71a7bdc4b30b
net_sched: remove a redundant goto chain check

All TC actions call tcf_action_check_ctrlact() to validate
goto chain, so this check in tcf_action_init_1() is actually
redundant. Remove it to save troubles of leaking memory.

Fixes: e49d8c22f126 ("net_sched: defer tcf_idr_insert() in tcf_action_init_1()")
Reported-by: Vlad Buslov <vladbu@mellanox.com>
Suggested-by: Davide Caratti <dcaratti@redhat.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Reviewed-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/act_api.c