]> www.infradead.org Git - users/willy/pagecache.git/commit
be2net: fix sleeping while atomic bugs in be_ndo_bridge_getlink
authorNikolay Aleksandrov <razor@blackwall.org>
Thu, 27 Feb 2025 16:41:29 +0000 (18:41 +0200)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 4 Mar 2025 10:14:15 +0000 (11:14 +0100)
commit1a82d19ca2d6835904ee71e2d40fd331098f94a0
tree45c97c67625405abdb3c06191b8b74d7b5e2564b
parent64e6a754d33d31aa844b3ee66fb93ac84ca1565e
be2net: fix sleeping while atomic bugs in be_ndo_bridge_getlink

Partially revert commit b71724147e73 ("be2net: replace polling with
sleeping in the FW completion path") w.r.t mcc mutex it introduces and the
use of usleep_range. The be2net be_ndo_bridge_getlink() callback is
called with rcu_read_lock, so this code has been broken for a long time.
Both the mutex_lock and the usleep_range can cause the issue Ian Kumlien
reported[1]. The call path is:
be_ndo_bridge_getlink -> be_cmd_get_hsw_config -> be_mcc_notify_wait ->
be_mcc_wait_compl -> usleep_range()

[1] https://lore.kernel.org/netdev/CAA85sZveppNgEVa_FD+qhOMtG_AavK9_mFiU+jWrMtXmwqefGA@mail.gmail.com/

Tested-by: Ian Kumlien <ian.kumlien@gmail.com>
Fixes: b71724147e73 ("be2net: replace polling with sleeping in the FW completion path")
Signed-off-by: Nikolay Aleksandrov <razor@blackwall.org>
Link: https://patch.msgid.link/20250227164129.1201164-1-razor@blackwall.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/emulex/benet/be.h
drivers/net/ethernet/emulex/benet/be_cmds.c
drivers/net/ethernet/emulex/benet/be_main.c