]> www.infradead.org Git - users/jedix/linux-maple.git/commit
nfs: Don't increment lock sequence ID after NFS4ERR_MOVED
authorChuck Lever <chuck.lever@oracle.com>
Sun, 22 Jan 2017 19:04:29 +0000 (14:04 -0500)
committerChuck Anderson <chuck.anderson@oracle.com>
Sun, 26 Feb 2017 21:58:53 +0000 (13:58 -0800)
commit1a61f53315ee3e64edd8af5e5d0557fd8e73a2c5
tree4cbcbd49143c6abd7d437ce0875029f7cb696061
parent64d93b7710a476385e62dde73993986fa86d5dc2
nfs: Don't increment lock sequence ID after NFS4ERR_MOVED

Xuan Qi reports that the Linux NFSv4 client failed to lock a file
that was migrated. The steps he observed on the wire:

1. The client sent a LOCK request to the source server
2. The source server replied NFS4ERR_MOVED
3. The client switched to the destination server
4. The client sent the same LOCK request to the destination
   server with a bumped lock sequence ID
5. The destination server rejected the LOCK request with
   NFS4ERR_BAD_SEQID

RFC 3530 section 8.1.5 provides a list of NFS errors which do not
bump a lock sequence ID.

However, RFC 3530 is now obsoleted by RFC 7530. In RFC 7530 section
9.1.7, this list has been updated by the addition of NFS4ERR_MOVED.

Reported-by: Xuan Qi <xuan.qi@oracle.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Cc: stable@vger.kernel.org # v3.7+
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Orabug: 25416941
(cherry picked from commit 059aa734824165507c65fd30a55ff000afd14983)
Signed-off-by: Todd Vierling <todd.vierling@oracle.com>
Reviewed-by: Jack Vogel <jack.vogel@oracle.com>
include/linux/nfs4.h