]> www.infradead.org Git - users/dwmw2/qemu.git/commit
hw/ide/ahci: PxCI should not get cleared when ERR_STAT is set
authorNiklas Cassel <niklas.cassel@wdc.com>
Fri, 9 Jun 2023 14:08:42 +0000 (16:08 +0200)
committerJohn Snow <jsnow@redhat.com>
Thu, 7 Sep 2023 02:48:04 +0000 (22:48 -0400)
commit1a16ce64fda11bdf50f0c4ab5d9fdde72c1383a2
tree0c436fdc8b66e309d4383fe01ef9a8a174233c66
parentd73b84d0b664e60fffb66f46e84d0db4a8e1c713
hw/ide/ahci: PxCI should not get cleared when ERR_STAT is set

For NCQ, PxCI is cleared on command queued successfully.
For non-NCQ, PxCI is cleared on command completed successfully.
Successfully means ERR_STAT, BUSY and DRQ are all cleared.

A command that has ERR_STAT set, does not get to clear PxCI.
See AHCI 1.3.1, section 5.3.8, states RegFIS:Entry and RegFIS:ClearCI,
and 5.3.16.5 ERR:FatalTaskfile.

In the case of non-NCQ commands, not clearing PxCI is needed in order
for host software to be able to see which command slot that failed.

Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
Message-id: 20230609140844.202795-7-nks@flawful.org
Signed-off-by: John Snow <jsnow@redhat.com>
hw/ide/ahci.c
tests/qtest/libqos/ahci.c
tests/qtest/libqos/ahci.h