]> www.infradead.org Git - users/jedix/linux-maple.git/commit
regulator: ad5398: change enable bit name to improve readibility
authorIsaac Scott <isaac.scott@ideasonboard.com>
Tue, 28 Jan 2025 17:31:41 +0000 (17:31 +0000)
committerMark Brown <broonie@kernel.org>
Mon, 3 Feb 2025 00:38:46 +0000 (00:38 +0000)
commit19d022d67d7353f0e6e9ba255435d3de93862ac4
tree81434590fe6ae831e5a79dfcaf64d9be51c03591
parent2014c95afecee3e76ca4a56956a936e23283f05b
regulator: ad5398: change enable bit name to improve readibility

The mask name AD5398_CURRENT_EN_MASK is misleading, as it implies that
setting bit 16 of the AD5398 enables current flow. In fact, setting this
bit prevents current flow, due to this bit being a software power down
control. This bit is referred to as "soft power down" in the datasheet.
As such, change the name of the bit and modify its use in the driver to
make the regulator more intuitively usable.

(When calling ad5398_enable, current will start flowing, and vice
versa).

Signed-off-by: Isaac Scott <isaac.scott@ideasonboard.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Link: https://patch.msgid.link/20250128173143.959600-2-isaac.scott@ideasonboard.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/ad5398.c