]> www.infradead.org Git - users/jedix/linux-maple.git/commit
wifi: ath11k: initialize 'ret' in ath11k_qmi_load_file_target_mem()
authorJeff Johnson <quic_jjohnson@quicinc.com>
Sat, 4 May 2024 18:52:09 +0000 (11:52 -0700)
committerKalle Valo <quic_kvalo@quicinc.com>
Mon, 13 May 2024 14:12:21 +0000 (17:12 +0300)
commit199f149e97dc7be80e5eed4b232529c1d1aa8055
tree4a908830dd17847974707f00b644232f457481a7
parentbb0b0a6b96e6de854cb1e349e17bd0e8bf421a59
wifi: ath11k: initialize 'ret' in ath11k_qmi_load_file_target_mem()

smatch flagged the following issue:

drivers/net/wireless/ath/ath11k/qmi.c:2401 ath11k_qmi_load_file_target_mem() error: uninitialized symbol 'ret'.

The reality is that 'ret' is initialized in every path through
ath11k_qmi_load_file_target_mem() except one, the case where the input
'len' is 0, and hence the "while (remaining)" loop is never entered.
But to make sure this case is also handled, add an initializer to the
declaration of 'ret'.

No functional changes, compile tested only.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://msgid.link/20240504-qmi_load_file_target_mem-v1-2-069fc44c45eb@quicinc.com
drivers/net/wireless/ath/ath11k/qmi.c