]> www.infradead.org Git - users/dwmw2/linux.git/commit
mt76: Fix a signedness bug in mt7615_add_interface()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 3 May 2019 12:54:36 +0000 (15:54 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 19 Sep 2019 07:11:02 +0000 (09:11 +0200)
commit195d154b8a711ee27fc7337a6988ce9acb66b73b
tree96d72311bdeca10e995639ac74632123af85ec12
parent76d64d6d9ed892d77e7478280827fa7e3a238e6e
mt76: Fix a signedness bug in mt7615_add_interface()

commit b1571a0e77d8cef14227af293c6dda1464a57270 upstream.

The problem is that "mvif->omac_idx" is a u8 so it can't be negative
and the error handling won't work.  The get_omac_idx() function returns
-1 on error.

Fixes: 04b8e65922f6 ("mt76: add mac80211 driver for MT7615 PCIe-based chipsets")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/mediatek/mt76/mt7615/main.c