]> www.infradead.org Git - users/dwmw2/openconnect.git/commit
Bugfix RSA SecurID token decryption and PIN entry forms
authorDaniel Lenski <dlenski@gmail.com>
Mon, 7 Mar 2022 16:50:13 +0000 (08:50 -0800)
committerDaniel Lenski <dlenski@gmail.com>
Tue, 8 Mar 2022 20:11:53 +0000 (12:11 -0800)
commit19417131895eb39aabf3641a9e4e0d7082b04f6d
treed712b97c66ed793465230b1e5690dc287cb3f2c9
parent70ffe7fb849eb421bf2e391104c1b5190e6fe686
Bugfix RSA SecurID token decryption and PIN entry forms

As of
https://gitlab.com/openconnect/openconnect/-/commit/386a6edb6d2d1d2cd3e9c9de8d85dc7bfda60d34,
all auth forms are required to have a non-NULL `auth_id`.

However, we forget to make stoken.c set the `auth_id` for the forms that it
creates for RSA SecurID token decryption and PIN entry.  Let's name these:

  - `_rsa_unlock`, for token decryption.
  - `_rsa_pin`, for PIN entry.  Also, rename the numeric PIN field to `pin`
    rather than `password`; there can't be any existing users relying on
    `--form-entry` to set its value, because that wouldn't work without the
    `auth_id`.

Fixes #388.

Signed-off-by: Daniel Lenski <dlenski@gmail.com>
stoken.c