]> www.infradead.org Git - users/jedix/linux-maple.git/commit
mailbox: arm_mhuv2: clean up loop in get_irq_chan_comb()
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 14 Nov 2024 09:00:12 +0000 (12:00 +0300)
committerJassi Brar <jassisinghbrar@gmail.com>
Sun, 24 Nov 2024 19:08:53 +0000 (13:08 -0600)
commit192a16a3430ca459c4e986f3d10758c4d6b1aa29
treef33d40258877a2595a5e6a5d668a185ff2cb94bc
parent98fc87fe2937db5a4948c553f69b5a3cc94c230a
mailbox: arm_mhuv2: clean up loop in get_irq_chan_comb()

Both the inner and outer loops in this code use the "i" iterator.
The inner loop should really use a different iterator.

It doesn't affect things in practice because the data comes from the
device tree.  The "protocol" and "windows" variables are going to be
zero.  That means we're always going to hit the "return &chans[channel];"
statement and we're not going to want to iterate through the outer
loop again.

Still it's worth fixing this for future use cases.

Fixes: 5a6338cce9f4 ("mailbox: arm_mhuv2: Add driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
drivers/mailbox/arm_mhuv2.c