]> www.infradead.org Git - users/jedix/linux-maple.git/commit
riscv/atomic: Do proper sign extension also for unsigned in arch_cmpxchg
authorAndreas Schwab <schwab@suse.de>
Thu, 30 Jan 2025 09:25:38 +0000 (10:25 +0100)
committerPalmer Dabbelt <palmer@rivosinc.com>
Fri, 14 Feb 2025 21:06:23 +0000 (13:06 -0800)
commit1898300abf3508bca152e65b36cce5bf93d7e63e
tree7e5dfa811916616d4599fcb72e61c0da1e5dcf1d
parentc6ec1e1b078d8e2ecd075e46db6197a14930a3fc
riscv/atomic: Do proper sign extension also for unsigned in arch_cmpxchg

Sign extend also an unsigned compare value to match what lr.w is doing.
Otherwise try_cmpxchg may spuriously return true when used on a u32 value
that has the sign bit set, as it happens often in inode_set_ctime_current.

Do this in three conversion steps.  The first conversion to long is needed
to avoid a -Wpointer-to-int-cast warning when arch_cmpxchg is used with a
pointer type.  Then convert to int and back to long to always sign extend
the 32-bit value to 64-bit.

Fixes: 6c58f25e6938 ("riscv/atomic: Fix sign extension for RV64I")
Signed-off-by: Andreas Schwab <schwab@suse.de>
Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com>
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
Tested-by: Xi Ruoyao <xry111@xry111.site>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/mvmed0k4prh.fsf@suse.de
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
arch/riscv/include/asm/cmpxchg.h