]> www.infradead.org Git - users/jedix/linux-maple.git/commit
platform/x86: mlx-platform: call pci_dev_put() to balance the refcount
authorJoe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Mon, 16 Dec 2024 02:25:38 +0000 (11:25 +0900)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tue, 17 Dec 2024 16:21:45 +0000 (18:21 +0200)
commit185e1b1d91e419445d3fd99c1c0376a970438acf
treee6f852a1097dce4240a82bce3f8cd0c667804bfd
parent83848e37f6ee80f60b04139fefdfa1bde4aaa826
platform/x86: mlx-platform: call pci_dev_put() to balance the refcount

mlxplat_pci_fpga_device_init() calls pci_get_device() but does not
release the refcount on error path. Call pci_dev_put() on the error path
and in mlxplat_pci_fpga_device_exit() to fix this.

This bug was found by an experimental static analysis tool that I am
developing.

Fixes: 02daa222fbdd ("platform: mellanox: Add initial support for PCIe based programming logic device")
Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Reviewed-by: Vadim Pasternak <vadimp@nvidia.com>
Link: https://lore.kernel.org/r/20241216022538.381209-1-joe@pf.is.s.u-tokyo.ac.jp
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/mlx-platform.c