]> www.infradead.org Git - nvme.git/commit
ublk: don't fail request for recovery & reissue in case of ubq->canceling
authorMing Lei <ming.lei@redhat.com>
Wed, 9 Apr 2025 01:14:42 +0000 (09:14 +0800)
committerJens Axboe <axboe@kernel.dk>
Wed, 9 Apr 2025 13:44:49 +0000 (07:44 -0600)
commit18461f2a02be04f8bbbe3b37fecfc702e3fa5bc2
tree89a32e8a1cb62c10f7b0c087316753ad89422ae9
parent6ee6bd5d4fce502a5b5a2ea805e9ff16e6aa890f
ublk: don't fail request for recovery & reissue in case of ubq->canceling

ubq->canceling is set with request queue quiesced when io_uring context is
exiting. USER_RECOVERY or !RECOVERY_FAIL_IO requires request to be re-queued
and re-dispatch after device is recovered.

However commit d796cea7b9f3 ("ublk: implement ->queue_rqs()") still may fail
any request in case of ubq->canceling, this way breaks USER_RECOVERY or
!RECOVERY_FAIL_IO.

Fix it by calling __ublk_abort_rq() in case of ubq->canceling.

Reviewed-by: Uday Shankar <ushankar@purestorage.com>
Reported-by: Uday Shankar <ushankar@purestorage.com>
Closes: https://lore.kernel.org/linux-block/Z%2FQkkTRHfRxtN%2FmB@dev-ushankar.dev.purestorage.com/
Fixes: d796cea7b9f3 ("ublk: implement ->queue_rqs()")
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20250409011444.2142010-3-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/ublk_drv.c