]> www.infradead.org Git - users/jedix/linux-maple.git/commit
platform/x86/intel/tpmi/plr: Fix output in plr_print_bits()
authorDan Carpenter <dan.carpenter@linaro.org>
Mon, 15 Jul 2024 20:22:55 +0000 (15:22 -0500)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tue, 16 Jul 2024 08:42:56 +0000 (11:42 +0300)
commit182c6941c55347c735e70ffca77741cd000cbec7
treeb7c68248bb691b7e8c84235ccf4ea36d44ef7b45
parent9d20c0535ea822e7306049bfc735bd0fb83400c1
platform/x86/intel/tpmi/plr: Fix output in plr_print_bits()

Smatch complains that 'str' can be used without being initialized:

    drivers/platform/x86/intel/intel_plr_tpmi.c:178 plr_print_bits()
    error: uninitialized symbol 'str'.

In this loop, we iterate over all the set bits and print the name of the
bit.  The intention is that if there is a bit which is between 0-31 we
look for the name in the first array plr_coarse_reasons[] which has 10
elements.  If the bit is in the 32-63 range we look for it in the
plr_fine_reasons[] array which has 30 elements.  If the bit is in the
invalid ranges, 10-31 or 62-63, then we should print "UNKNOWN(%d)".

The problem is that 'str' needs to be initialized at the start of each
iteration, otherwise if we can't find the string then instead of printing
"UNKNOWN(%d)", we will re-print whatever the previous bit was.

Fixes: 9e9397a41b7b ("platform/x86/intel/tpmi/plr: Add support for the plr mailbox")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/b0084e70-4144-445a-9b89-fb19f6b8336a@stanley.mountain
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/intel/intel_plr_tpmi.c