]> www.infradead.org Git - users/jedix/linux-maple.git/commit
PM: EM: Fix potential division-by-zero error in em_compute_costs()
authorYaxiong Tian <tianyaxiong@kylinos.cn>
Fri, 18 Apr 2025 01:06:13 +0000 (09:06 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 28 Apr 2025 13:28:59 +0000 (15:28 +0200)
commit179c0c7044a378198adb36f2a12410ab68cc730a
tree58f29002ae799e16a13e06016a7f44baae013de2
parentb4432656b36e5cc1d50a1f2dc15357543add530e
PM: EM: Fix potential division-by-zero error in em_compute_costs()

When the device is of a non-CPU type, table[i].performance won't be
initialized in the previous em_init_performance(), resulting in division
by zero when calculating costs in em_compute_costs().

Since the 'cost' algorithm is only used for EAS energy efficiency
calculations and is currently not utilized by other device drivers, we
should add the _is_cpu_device(dev) check to prevent this division-by-zero
issue.

Fixes: 1b600da51073 ("PM: EM: Optimize em_cpu_energy() and remove division")
Signed-off-by: Yaxiong Tian <tianyaxiong@kylinos.cn>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Link: https://patch.msgid.link/tencent_7F99ED4767C1AF7889D0D8AD50F34859CE06@qq.com
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
kernel/power/energy_model.c