]> www.infradead.org Git - users/willy/pagecache.git/commit
treewide: const qualify ctl_tables where applicable
authorJoel Granados <joel.granados@kernel.org>
Tue, 28 Jan 2025 12:48:37 +0000 (13:48 +0100)
committerJoel Granados <joel.granados@kernel.org>
Tue, 28 Jan 2025 12:48:37 +0000 (13:48 +0100)
commit1751f872cc97f992ed5c4c72c55588db1f0021e1
tree7b34e6eaeb91dbac0805344504ddc176c1180be2
parent6d61a53dd6f55405ebcaea6ee38d1ab5a8856c2c
treewide: const qualify ctl_tables where applicable

Add the const qualifier to all the ctl_tables in the tree except for
watchdog_hardlockup_sysctl, memory_allocation_profiling_sysctls,
loadpin_sysctl_table and the ones calling register_net_sysctl (./net,
drivers/inifiniband dirs). These are special cases as they use a
registration function with a non-const qualified ctl_table argument or
modify the arrays before passing them on to the registration function.

Constifying ctl_table structs will prevent the modification of
proc_handler function pointers as the arrays would reside in .rodata.
This is made possible after commit 78eb4ea25cd5 ("sysctl: treewide:
constify the ctl_table argument of proc_handlers") constified all the
proc_handlers.

Created this by running an spatch followed by a sed command:
Spatch:
    virtual patch

    @
    depends on !(file in "net")
    disable optional_qualifier
    @

    identifier table_name != {
      watchdog_hardlockup_sysctl,
      iwcm_ctl_table,
      ucma_ctl_table,
      memory_allocation_profiling_sysctls,
      loadpin_sysctl_table
    };
    @@

    + const
    struct ctl_table table_name [] = { ... };

sed:
    sed --in-place \
      -e "s/struct ctl_table .table = &uts_kern/const struct ctl_table *table = \&uts_kern/" \
      kernel/utsname_sysctl.c

Reviewed-by: Song Liu <song@kernel.org>
Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org> # for kernel/trace/
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com> # SCSI
Reviewed-by: Darrick J. Wong <djwong@kernel.org> # xfs
Acked-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Corey Minyard <cminyard@mvista.com>
Acked-by: Wei Liu <wei.liu@kernel.org>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Bill O'Donnell <bodonnel@redhat.com>
Acked-by: Baoquan He <bhe@redhat.com>
Acked-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Acked-by: Anna Schumaker <anna.schumaker@oracle.com>
Signed-off-by: Joel Granados <joel.granados@kernel.org>
106 files changed:
arch/arm/kernel/isa.c
arch/arm64/kernel/fpsimd.c
arch/arm64/kernel/process.c
arch/powerpc/kernel/idle.c
arch/powerpc/platforms/pseries/mobility.c
arch/riscv/kernel/process.c
arch/riscv/kernel/vector.c
arch/s390/appldata/appldata_base.c
arch/s390/kernel/debug.c
arch/s390/kernel/hiperdispatch.c
arch/s390/kernel/topology.c
arch/s390/mm/cmm.c
arch/s390/mm/pgalloc.c
arch/x86/entry/vdso/vdso32-setup.c
arch/x86/kernel/cpu/bus_lock.c
crypto/fips.c
drivers/base/firmware_loader/fallback_table.c
drivers/cdrom/cdrom.c
drivers/char/hpet.c
drivers/char/ipmi/ipmi_poweroff.c
drivers/char/random.c
drivers/gpu/drm/i915/i915_perf.c
drivers/gpu/drm/xe/xe_observation.c
drivers/hv/hv_common.c
drivers/md/md.c
drivers/misc/sgi-xp/xpc_main.c
drivers/perf/arm_pmuv3.c
drivers/perf/riscv_pmu_sbi.c
drivers/scsi/scsi_sysctl.c
drivers/scsi/sg.c
drivers/tty/tty_io.c
drivers/xen/balloon.c
fs/aio.c
fs/cachefiles/error_inject.c
fs/coda/sysctl.c
fs/coredump.c
fs/dcache.c
fs/devpts/inode.c
fs/eventpoll.c
fs/exec.c
fs/file_table.c
fs/fuse/sysctl.c
fs/inode.c
fs/lockd/svc.c
fs/locks.c
fs/namei.c
fs/namespace.c
fs/nfs/nfs4sysctl.c
fs/nfs/sysctl.c
fs/notify/dnotify/dnotify.c
fs/notify/fanotify/fanotify_user.c
fs/notify/inotify/inotify_user.c
fs/ocfs2/stackglue.c
fs/pipe.c
fs/quota/dquot.c
fs/sysctls.c
fs/userfaultfd.c
fs/verity/init.c
fs/xfs/xfs_sysctl.c
init/do_mounts_initrd.c
io_uring/io_uring.c
ipc/ipc_sysctl.c
ipc/mq_sysctl.c
kernel/acct.c
kernel/bpf/syscall.c
kernel/delayacct.c
kernel/exit.c
kernel/hung_task.c
kernel/kexec_core.c
kernel/kprobes.c
kernel/latencytop.c
kernel/locking/lockdep.c
kernel/panic.c
kernel/pid.c
kernel/pid_namespace.c
kernel/pid_sysctl.h
kernel/printk/sysctl.c
kernel/reboot.c
kernel/sched/autogroup.c
kernel/sched/core.c
kernel/sched/deadline.c
kernel/sched/fair.c
kernel/sched/rt.c
kernel/sched/topology.c
kernel/seccomp.c
kernel/signal.c
kernel/stackleak.c
kernel/sysctl-test.c
kernel/sysctl.c
kernel/time/timer.c
kernel/trace/ftrace.c
kernel/trace/trace_events_user.c
kernel/umh.c
kernel/utsname_sysctl.c
kernel/watchdog.c
lib/test_sysctl.c
mm/compaction.c
mm/hugetlb.c
mm/hugetlb_vmemmap.c
mm/memory-failure.c
mm/oom_kill.c
mm/page-writeback.c
mm/page_alloc.c
security/apparmor/lsm.c
security/keys/sysctl.c
security/yama/yama_lsm.c