]> www.infradead.org Git - users/dwmw2/linux.git/commit
serial: 8250: omap: Disable DMA for console UART
authorVignesh R <vigneshr@ti.com>
Sat, 22 Apr 2017 13:07:19 +0000 (18:37 +0530)
committerSasha Levin <alexander.levin@microsoft.com>
Wed, 23 May 2018 01:36:24 +0000 (21:36 -0400)
commit17308dcf6471525f53ff59c68fcf097a39c2db81
tree24de86bdd9e9cb28c23d7d5c05699ba4d5748969
parent2e007af552eb1de59e466270c581282a4596d619
serial: 8250: omap: Disable DMA for console UART

[ Upstream commit 84b40e3b57eef1417479c00490dd4c9f6e5ffdbc ]

Kernel always writes log messages to console via
serial8250_console_write()->serial8250_console_putchar() which directly
accesses UART_TX register _without_ using DMA.

But, if other processes like systemd using same UART port, then these
writes are handled by a different code flow using 8250_omap driver where
there is provision to use DMA.

It seems that it is possible that both DMA and CPU might simultaneously
put data to UART FIFO and lead to potential loss of data due to FIFO
overflow and weird data corruption. This happens when both kernel
console and userspace tries to write simultaneously to the same UART
port. Therefore, disable DMA on kernel console port to avoid potential
race between CPU and DMA.

Signed-off-by: Vignesh R <vigneshr@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
drivers/tty/serial/8250/8250_omap.c