]> www.infradead.org Git - users/jedix/linux-maple.git/commit
selftests: tpm2: test_smoke: use POSIX-conformant expression operator
authorAhmed Salem <x0rw3ll@gmail.com>
Tue, 11 Feb 2025 23:16:17 +0000 (01:16 +0200)
committerShuah Khan <skhan@linuxfoundation.org>
Tue, 8 Apr 2025 20:56:13 +0000 (14:56 -0600)
commit170ec11935de4acced0ae001562cca3a144acd67
tree4d8e7fdef344c9b14f753ecad37273a325da27aa
parent5cd2950359ef31c9e273588c33f372ff8e546e2e
selftests: tpm2: test_smoke: use POSIX-conformant expression operator

Use POSIX-conformant expression operator symbol '='.

The use of the non POSIX-conformant symbol '==' would work
in bash, but not in sh where the unexpected operator error
would result in test_smoke.sh being skipped.

Instead of changing the shebang to use bash, which may not be
available on all systems, use the POSIX-conformant expression
symbol '=' to test for equality.

Without this patch:
===================
 # make -j8 TARGETS=tpm2 kselftest
 # selftests: tpm2: test_smoke.sh
 # ./test_smoke.sh: 9: [: 2: unexpected operator
 ok 1 selftests: tpm2: test_smoke.sh # SKIP

With this patch:
================
 # make -j8 TARGETS=tpm2 kselftest
 # selftests: tpm2: test_smoke.sh
 # Ran 9 tests in 9.236s
 ok 1 selftests: tpm2: test_smoke.sh

Link: https://lore.kernel.org/r/37ztyakgrrtgvec344mg7mspchwjpxxtsprtjidso3pwkmm4f4@awsa5mzgqmtb
Signed-off-by: Ahmed Salem <x0rw3ll@gmail.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
tools/testing/selftests/tpm2/test_smoke.sh