]> www.infradead.org Git - users/jedix/linux-maple.git/commit
genirq: fix regression in irqfixup, irqpoll
authorEdward Donovan <edward.donovan@numble.net>
Mon, 28 Nov 2011 04:07:34 +0000 (23:07 -0500)
committerMaxim Uvarov <maxim.uvarov@oracle.com>
Fri, 16 Dec 2011 01:14:25 +0000 (17:14 -0800)
commit170805c4e1f8715f495ff09a74b40aae633561ce
tree415ced0651999b68c33f8827605b6edc37debbf5
parentc37f38ef48ba3e156d8bb1b228b7066e07c0a690
genirq: fix regression in irqfixup, irqpoll

commit 52553ddffad76ccf192d4dd9ce88d5818f57f62a upstream.

Commit fa27271bc8d2("genirq: Fixup poll handling") introduced a
regression that broke irqfixup/irqpoll for some hardware configurations.

Amidst reorganizing 'try_one_irq', that patch removed a test that
checked for 'action->handler' returning IRQ_HANDLED, before acting on
the interrupt.  Restoring this test back returns the functionality lost
since 2.6.39.  In the current set of tests, after 'action' is set, it
must precede '!action->next' to take effect.

With this and my previous patch to irq/spurious.c, c75d720fca8a, all
IRQ regressions that I have encountered are fixed.

Signed-off-by: Edward Donovan <edward.donovan@numble.net>
Reported-and-tested-by: Rogério Brito <rbrito@ime.usp.br>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
kernel/irq/spurious.c