]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/amd/display: Explicitly cast v_total to signed in a subtraction
authorAlex Hung <alex.hung@amd.com>
Thu, 30 May 2024 00:05:20 +0000 (18:05 -0600)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 14 Jun 2024 20:18:25 +0000 (16:18 -0400)
commit1608e201df49127376d9fff1284b8b3c5e018440
tree328112e65de3fc16b5bdc35e63a346638727432d
parent2037646406ad0be7a89687a0333b7b40f50f9b33
drm/amd/display: Explicitly cast v_total to signed in a subtraction

[WHY & HOW]
v_total is an uint32_t and subtracting an unsigned to a signed will
result in an unsigned which is always >= 0. As a result, the ternary
conditions are always true and thus has no effect.

This is fixed by casting v_total to signed explicitly. This also
avoids v_total subtraction to overflow.

This fixes 1 NO_EFFECT, 2 DEADCODE and 2 INTEGER_OVERFLOW issues reported
by Coverity.

Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Acked-by: Zaeem Mohamed <zaeem.mohamed@amd.com>
Signed-off-by: Alex Hung <alex.hung@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/core/dc_stream.c