]> www.infradead.org Git - users/dwmw2/linux.git/commit
fs: Fix uninitialized value issue in from_kuid and from_kgid
authorAlessandro Zanni <alessandro.zanni87@gmail.com>
Thu, 17 Oct 2024 12:05:51 +0000 (14:05 +0200)
committerChristian Brauner <brauner@kernel.org>
Thu, 17 Oct 2024 13:33:43 +0000 (15:33 +0200)
commit15f34347481648a567db67fb473c23befb796af5
treef2d10d4b9f9f1c67abbba38bb53381c188ee5028
parent229fd15908fe1f99b1de4cde3326e62d1e892611
fs: Fix uninitialized value issue in from_kuid and from_kgid

ocfs2_setattr() uses attr->ia_mode, attr->ia_uid and attr->ia_gid in
a trace point even though ATTR_MODE, ATTR_UID and ATTR_GID aren't set.

Initialize all fields of newattrs to avoid uninitialized variables, by
checking if ATTR_MODE, ATTR_UID, ATTR_GID are initialized, otherwise 0.

Reported-by: syzbot+6c55f725d1bdc8c52058@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=6c55f725d1bdc8c52058
Signed-off-by: Alessandro Zanni <alessandro.zanni87@gmail.com>
Link: https://lore.kernel.org/r/20241017120553.55331-1-alessandro.zanni87@gmail.com
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/ocfs2/file.c