]> www.infradead.org Git - users/jedix/linux-maple.git/commit
rust: file: mark `LocalFile` as `repr(transparent)`
authorPekka Ristola <pekkarr@protonmail.com>
Tue, 27 May 2025 20:48:55 +0000 (20:48 +0000)
committerChristian Brauner <brauner@kernel.org>
Fri, 30 May 2025 05:12:05 +0000 (07:12 +0200)
commit15ecd83dc06277385ad71dc7ea26911d9a79acaf
tree650070c17216b329e04f93c56d2872af0a5c67a1
parent34ecde3c56066ba79e5ec3d93c5b14ea83e3603e
rust: file: mark `LocalFile` as `repr(transparent)`

Unsafe code in `LocalFile`'s methods assumes that the type has the same
layout as the inner `bindings::file`. This is not guaranteed by the default
struct representation in Rust, but requires specifying the `transparent`
representation.

The `File` struct (which also wraps `bindings::file`) is already marked as
`repr(transparent)`, so this change makes their layouts equivalent.

Fixes: 851849824bb5 ("rust: file: add Rust abstraction for `struct file`")
Closes: https://github.com/Rust-for-Linux/linux/issues/1165
Signed-off-by: Pekka Ristola <pekkarr@protonmail.com>
Link: https://lore.kernel.org/20250527204636.12573-1-pekkarr@protonmail.com
Reviewed-by: Benno Lossin <lossin@kernel.org>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
rust/kernel/fs/file.rs