]> www.infradead.org Git - users/jedix/linux-maple.git/commit
xen/pciback: Fix conf_space read/write overlap check.
authorAndrey Grodzovsky <andrey2805@gmail.com>
Tue, 21 Jun 2016 18:26:36 +0000 (14:26 -0400)
committerKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Wed, 6 Jul 2016 16:13:31 +0000 (12:13 -0400)
commit150acc10c4b6568983a72831d5641adfd0bb2f2d
tree984fc12f02bf81a039412bfb92229a7d18a11a60
parent0dc843ff5d9e60dd041d48ecdfc4fb8338724bbb
xen/pciback: Fix conf_space read/write overlap check.

Current overlap check is evaluating to false a case where a filter
field is fully contained (proper subset) of a r/w request.  This
change applies classical overlap check instead to include all the
scenarios.

More specifically, for (Hilscher GmbH CIFX 50E-DP(M/S)) device driver
the logic is such that the entire confspace is read and written in 4
byte chunks. In this case as an example, CACHE_LINE_SIZE,
LATENCY_TIMER and PCI_BIST are arriving together in one call to
xen_pcibk_config_write() with offset == 0xc and size == 4.  With the
exsisting overlap check the LATENCY_TIMER field (offset == 0xd, length
== 1) is fully contained in the write request and hence is excluded
from write, which is incorrect.

Signed-off-by: Andrey Grodzovsky <andrey2805@gmail.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Reviewed-by: Jan Beulich <JBeulich@suse.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
(cherry picked from commit 02ef871ecac290919ea0c783d05da7eedeffc10e)
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
OraBug: 23585393
drivers/xen/xen-pciback/conf_space.c