]> www.infradead.org Git - users/jedix/linux-maple.git/commit
llc: Improve setsockopt() handling of malformed user input
authorMichal Luczaj <mhal@rbox.co>
Tue, 19 Nov 2024 13:31:41 +0000 (14:31 +0100)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 28 Nov 2024 07:57:42 +0000 (08:57 +0100)
commit1465036b10be4b8b00eb31c879e86de633ad74c1
tree1094d8a2f4978549b5d2999fbd7abe780305dcf8
parent5dfd7d940094e1a1ec974d90f6d28162d372b56b
llc: Improve setsockopt() handling of malformed user input

copy_from_sockptr() is used incorrectly: return value is the number of
bytes that could not be copied. Since it's deprecated, switch to
copy_safe_from_sockptr().

Note: Keeping the `optlen != sizeof(int)` check as copy_safe_from_sockptr()
by itself would also accept optlen > sizeof(int). Which would allow a more
lenient handling of inputs.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Suggested-by: David Wei <dw@davidwei.uk>
Signed-off-by: Michal Luczaj <mhal@rbox.co>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/llc/af_llc.c