]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/amd/display: Explicitly extend unsigned 16 bit to 64 bit
authorAlex Hung <alex.hung@amd.com>
Wed, 5 Jun 2024 18:37:18 +0000 (12:37 -0600)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 14 Jun 2024 20:18:55 +0000 (16:18 -0400)
commit143818fae047fdda55d06651e4d7ab9dc7afe669
tree32309dcac2518ceae0c0b0da87424225af2ce0d5
parent0057b36ac2be0f573048acda52e641e0502a9ff3
drm/amd/display: Explicitly extend unsigned 16 bit to 64 bit

Coverity reports sign extention defects as below:

Suspicious implicit sign extension: mode->htotal with type u16 ... to
int (32 bits, signed), then sign-extended to type unsigned long
(64 bits, unsigned). If mode->htotal * mode->vtotal is greater than
0x7FFFFFFF, the upper bits of the result will all be 1.

Cast it to unsigned long to avoid possible overflow.

This fixes 4 SIGN_EXTENSION issues reported by Coverity.

Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Acked-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
Signed-off-by: Alex Hung <alex.hung@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c