]> www.infradead.org Git - users/dwmw2/linux.git/commit
media: imx-jpeg: Fix potential error pointer dereference in detach_pm()
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 17 Oct 2024 20:34:16 +0000 (23:34 +0300)
committerHans Verkuil <hverkuil@xs4all.nl>
Mon, 2 Dec 2024 13:05:22 +0000 (14:05 +0100)
commit1378ffec30367233152b7dbf4fa6a25ee98585d1
tree77c0a431d1030c61ee83bff62c96612a071caea7
parent27dcdb63aac76a637a5a18a4065b442cc182d883
media: imx-jpeg: Fix potential error pointer dereference in detach_pm()

The proble is on the first line:

if (jpeg->pd_dev[i] && !pm_runtime_suspended(jpeg->pd_dev[i]))

If jpeg->pd_dev[i] is an error pointer, then passing it to
pm_runtime_suspended() will lead to an Oops.  The other conditions
check for both error pointers and NULL, but it would be more clear to
use the IS_ERR_OR_NULL() check for that.

Fixes: fd0af4cd35da ("media: imx-jpeg: Ensure power suppliers be suspended before detach them")
Cc: <stable@vger.kernel.org>
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Ming Qian <ming.qian@nxp.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c