]> www.infradead.org Git - users/dwmw2/linux.git/commit
bpf: Fix out-of-bounds write in trie_get_next_key()
authorByeonguk Jeong <jungbu2855@gmail.com>
Sat, 26 Oct 2024 05:02:43 +0000 (14:02 +0900)
committerAlexei Starovoitov <ast@kernel.org>
Tue, 29 Oct 2024 20:41:40 +0000 (13:41 -0700)
commit13400ac8fb80c57c2bfb12ebd35ee121ce9b4d21
treecda75874d697a484f3860d50709212ecb1ace4da
parent1fb315892d8395cec2dae04b0cb5558731aefb37
bpf: Fix out-of-bounds write in trie_get_next_key()

trie_get_next_key() allocates a node stack with size trie->max_prefixlen,
while it writes (trie->max_prefixlen + 1) nodes to the stack when it has
full paths from the root to leaves. For example, consider a trie with
max_prefixlen is 8, and the nodes with key 0x00/0, 0x00/1, 0x00/2, ...
0x00/8 inserted. Subsequent calls to trie_get_next_key with _key with
.prefixlen = 8 make 9 nodes be written on the node stack with size 8.

Fixes: b471f2f1de8b ("bpf: implement MAP_GET_NEXT_KEY command for LPM_TRIE map")
Signed-off-by: Byeonguk Jeong <jungbu2855@gmail.com>
Reviewed-by: Toke Høiland-Jørgensen <toke@kernel.org>
Tested-by: Hou Tao <houtao1@huawei.com>
Acked-by: Hou Tao <houtao1@huawei.com>
Link: https://lore.kernel.org/r/Zxx384ZfdlFYnz6J@localhost.localdomain
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/bpf/lpm_trie.c