]> www.infradead.org Git - users/hch/misc.git/commit
net/ipv6: set expires in rt6_add_dflt_router().
authorKui-Feng Lee <thinker.li@gmail.com>
Thu, 8 Feb 2024 22:06:49 +0000 (14:06 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 12 Feb 2024 10:24:12 +0000 (10:24 +0000)
commit129e406e1811538c1afc9c8e97d61bb18eed3363
treebb223ddcf21cf7c09effaed87a03d642d3530c17
parent9c52994e32c5d8aaff13b1a13f7b35b988b02b26
net/ipv6: set expires in rt6_add_dflt_router().

Pass the duration of a lifetime (in seconds) to the function
rt6_add_dflt_router() so that it can properly set the expiration time.

The function ndisc_router_discovery() is the only one that calls
rt6_add_dflt_router(), and it will later set the expiration time for the
route created by rt6_add_dflt_router(). However, there is a gap of time
between calling rt6_add_dflt_router() and setting the expiration time in
ndisc_router_discovery(). During this period, there is a possibility that a
new route may be removed from the routing table. By setting the correct
expiration time in rt6_add_dflt_router(), we can prevent this from
happening. The reason for setting RTF_EXPIRES in rt6_add_dflt_router() is
to start the Garbage Collection (GC) timer, as it only activates when a
route with RTF_EXPIRES is added to a table.

Suggested-by: David Ahern <dsahern@kernel.org>
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Signed-off-by: Kui-Feng Lee <thinker.li@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/ip6_route.h
net/ipv6/ndisc.c
net/ipv6/route.c