]> www.infradead.org Git - users/hch/dma-mapping.git/commit
netfilter: bpf: must hold reference on net namespace
authorFlorian Westphal <fw@strlen.de>
Thu, 10 Oct 2024 16:34:05 +0000 (18:34 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Thu, 17 Oct 2024 11:58:57 +0000 (13:58 +0200)
commit1230fe7ad3974f7bf6c78901473e039b34d4fb1f
tree9dbc0104d2d74765838f5d5e6a6afc832ad09428
parentcb560795c8c2ceca1d36a95f0d1b2eafc4074e37
netfilter: bpf: must hold reference on net namespace

BUG: KASAN: slab-use-after-free in __nf_unregister_net_hook+0x640/0x6b0
Read of size 8 at addr ffff8880106fe400 by task repro/72=
bpf_nf_link_release+0xda/0x1e0
bpf_link_free+0x139/0x2d0
bpf_link_release+0x68/0x80
__fput+0x414/0xb60

Eric says:
 It seems that bpf was able to defer the __nf_unregister_net_hook()
 after exit()/close() time.
 Perhaps a netns reference is missing, because the netns has been
 dismantled/freed already.
 bpf_nf_link_attach() does :
 link->net = net;
 But I do not see a reference being taken on net.

Add such a reference and release it after hook unreg.
Note that I was unable to get syzbot reproducer to work, so I
do not know if this resolves this splat.

Fixes: 84601d6ee68a ("bpf: add bpf_link support for BPF_NETFILTER programs")
Diagnosed-by: Eric Dumazet <edumazet@google.com>
Reported-by: Lai, Yi <yi1.lai@linux.intel.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_bpf_link.c