]> www.infradead.org Git - users/jedix/linux-maple.git/commit
fault-injection: enhance failcmd to exit on non-hex address input
authorBreno Leitao <leitao@debian.org>
Mon, 29 Jul 2024 08:45:08 +0000 (01:45 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 2 Sep 2024 03:43:31 +0000 (20:43 -0700)
commit11ee88a0f98770719f29b7d1efb2a2ca6a83af3c
tree17ee4aa554a333029a87a9b6a60ea4b3e2ab5dc9
parent588661fd87a79c89b506abdba186cb58c07a5dfc
fault-injection: enhance failcmd to exit on non-hex address input

The failcmd.sh script in the fault-injection toolkit does not currently
validate whether the provided address is in hexadecimal format.  This can
lead to silent failures if the address is sourced from places like
`/proc/kallsyms`, which omits the '0x' prefix, potentially causing users
to operate under incorrect assumptions.

Introduce a new function, `exit_if_not_hex`, which checks the format of
the provided address and exits with an error message if the address is not
a valid hexadecimal number.

This enhancement prevents users from running the command with improperly
formatted addresses, thus improving the robustness and usability of the
failcmd tool.

Link: https://lkml.kernel.org/r/20240729084512.3349928-1-leitao@debian.org
Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
tools/testing/fault-injection/failcmd.sh