]> www.infradead.org Git - users/jedix/linux-maple.git/commit
bio: return EINTR if copying to user space got interrupted
authorHannes Reinecke <hare@suse.de>
Fri, 12 Feb 2016 08:39:15 +0000 (09:39 +0100)
committerChuck Anderson <chuck.anderson@oracle.com>
Thu, 26 May 2016 22:45:04 +0000 (15:45 -0700)
commit11c80661cf9a493adcfe549bb942b318099de592
treec66b85a6181d09c9e35c7bc345e119fc4f8d3ca4
parent99e5410861834fa9758dccf0260aef82a5d4012d
bio: return EINTR if copying to user space got interrupted

Orabug: 23330862

[ Upstream commit 2d99b55d378c996b9692a0c93dd25f4ed5d58934 ]

Commit 35dc248383bbab0a7203fca4d722875bc81ef091 introduced a check for
current->mm to see if we have a user space context and only copies data
if we do. Now if an IO gets interrupted by a signal data isn't copied
into user space any more (as we don't have a user space context) but
user space isn't notified about it.

This patch modifies the behaviour to return -EINTR from bio_uncopy_user()
to notify userland that a signal has interrupted the syscall, otherwise
it could lead to a situation where the caller may get a buffer with
no data returned.

This can be reproduced by issuing SG_IO ioctl()s in one thread while
constantly sending signals to it.

Fixes: 35dc248 [SCSI] sg: Fix user memory corruption when SG_IO is interrupted by a signal
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Hannes Reinecke <hare@suse.de>
Cc: stable@vger.kernel.org # v.3.11+
Signed-off-by: Jens Axboe <axboe@fb.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
(cherry picked from commit f3dd341b9230ac943f317efa4c5b1bfae587434b)

Signed-off-by: Dan Duval <dan.duval@oracle.com>
block/bio.c