]> www.infradead.org Git - users/jedix/linux-maple.git/commit
r8169: RxConfig hack for the 8168evl.
authorfrançois romieu <romieu@fr.zoreil.com>
Wed, 20 Jun 2012 12:09:18 +0000 (12:09 +0000)
committerJoe Jin <joe.jin@oracle.com>
Wed, 29 Aug 2012 00:22:21 +0000 (08:22 +0800)
commit11a37da97883d7ef9969eaa5cbc6e94249a2b5b4
tree7ea255d0252b920a8510ad86b2ae9a8e95648553
parenteb8af00704c5225d855024380b49300914688ed6
r8169: RxConfig hack for the 8168evl.

The 8168evl (RTL_GIGA_MAC_VER_34) based Gigabyte GA-990FXA motherboards
are very prone to NETDEV watchdog problems without this change. See
https://bugzilla.kernel.org/show_bug.cgi?id=42899 for instance.

I don't know why it *works*. It's depressingly effective though.

For the record:
- the problem may go along IOMMU (AMD-Vi) errors but it really looks
  like a red herring.
- the patch sets the RX_MULTI_EN bit. If the 8168c doc is any guide,
  the chipset now fetches several Rx descriptors at a time.
- long ago the driver ignored the RX_MULTI_EN bit.
  e542a2269f232d61270ceddd42b73a4348dee2bb changed the RxConfig
  settings. Whatever the problem it's now labeled a regression.
- Realtek's own driver can identify two different 8168evl devices
  (CFG_METHOD_16 and CFG_METHOD_17) where the r8169 driver only
  sees one. It sucks.

(cherry picked from commit eb2dc35d99028b698cdedba4f5522bc43e576bd2)
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Joe Jin <joe.jin@oracle.com>
drivers/net/r8169.c