]> www.infradead.org Git - users/willy/pagecache.git/commit
net/mlx5: DR, prevent potential error pointer dereference
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 4 Dec 2024 12:06:41 +0000 (15:06 +0300)
committerJakub Kicinski <kuba@kernel.org>
Fri, 6 Dec 2024 02:45:09 +0000 (18:45 -0800)
commit11776cff0b563c8b8a4fa76cab620bfb633a8cb8
tree35bac3ea6bac688d5849dda8eac88127e8b89c12
parentb04d86fff66b15c07505d226431f808c15b1703c
net/mlx5: DR, prevent potential error pointer dereference

The dr_domain_add_vport_cap() function generally returns NULL on error
but sometimes we want it to return ERR_PTR(-EBUSY) so the caller can
retry.  The problem here is that "ret" can be either -EBUSY or -ENOMEM
and if it's and -ENOMEM then the error pointer is propogated back and
eventually dereferenced in dr_ste_v0_build_src_gvmi_qpn_tag().

Fixes: 11a45def2e19 ("net/mlx5: DR, Add support for SF vports")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/07477254-e179-43e2-b1b3-3b9db4674195@stanley.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_domain.c