]> www.infradead.org Git - users/jedix/linux-maple.git/commit
usb: misc: onboard_usb_dev: Fix usb5744 initialization sequence
authorJonathan Stroud <jonathan.stroud@amd.com>
Fri, 16 May 2025 12:32:40 +0000 (18:02 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 21 May 2025 11:14:28 +0000 (13:14 +0200)
commit1143d41922c0f87504f095417ba1870167970143
tree8b55172a5d8b171cf4b40462e8c92b60d1d59a1a
parentd01ccb5b62b753c7ce527b1b38834c0ad2e9ae50
usb: misc: onboard_usb_dev: Fix usb5744 initialization sequence

Introduce i2c APIs to read/write for proper configuration register
programming. It ensures that read-modify-write sequence is performed
and reserved bit in Runtime Flags 2 register are not touched.

Also legacy smbus block write inserted an extra count value into the
i2c data stream which breaks the register write on the usb5744.

Switching to new read/write i2c APIs fixes both issues.

Fixes: 6782311d04df ("usb: misc: onboard_usb_dev: add Microchip usb5744 SMBus programming support")
Cc: stable <stable@kernel.org>
Signed-off-by: Jonathan Stroud <jonathan.stroud@amd.com>
Co-developed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Link: https://lore.kernel.org/r/1747398760-284021-1-git-send-email-radhey.shyam.pandey@amd.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/misc/onboard_usb_dev.c