]> www.infradead.org Git - users/jedix/linux-maple.git/commit
iio: dac: ad3530r: Fix incorrect masking for channels 4-7 in powerdown mode
authorKim Seer Paller <kimseer.paller@analog.com>
Thu, 26 Jun 2025 08:38:12 +0000 (16:38 +0800)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 29 Jun 2025 16:15:40 +0000 (17:15 +0100)
commit1131e70558bc70f1fc52515281de2663e961e1cc
treec2435dcb111ab6e5d834574cbd30ec09d6663e91
parent24fa69894ea3f76ecb13d7160692ee574a912803
iio: dac: ad3530r: Fix incorrect masking for channels 4-7 in powerdown mode

In the current implementation of ad3530r_set_dac_powerdown() function,
the macro AD3530R_OP_MODE_CHAN_MSK(chan->channel) is used to generate
the bitmask for the operating mode of a specific channel. However, this
macro does not account for channels 4-7, which map to the second
register AD3530R_OUTPUT_OPERATING_MODE_1 for the 8 channeled device. As
a result, the bitmask is incorrectly calculated for these channels,
leading to improper configuration of the powerdown mode. Resolve this
issue by adjusting the channel index for channels 4-7 by subtracting 4
before applying the macro. This ensures that the correct bitmask is
generated for the second register.

Fixes: 93583174a3df ("iio: dac: ad3530r: Add driver for AD3530R and AD3531R")
Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
Reviewed-by: David Lechner <dlechner@baylibre.com>
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Link: https://patch.msgid.link/20250626-bug_fix-v1-1-eb3c2b370f10@analog.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/dac/ad3530r.c